Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing machine type to Kubernetes provider #746

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Add missing machine type to Kubernetes provider #746

merged 1 commit into from
Mar 30, 2023

Conversation

ludelafo
Copy link
Contributor

@ludelafo ludelafo commented Mar 29, 2023

The documentation states a list of common machine types: https://registry.terraform.io/providers/iterative/iterative/latest/docs/resources/task#machine-type and https://github.com/iterative/terraform-provider-iterative/blob/main/docs/guides/generic-machine-types.md

I did notice the Kubernetes provider is missing the s machine type from the list. This pull request fixes this.

Copy link
Contributor

@dacbd dacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @0x2b3bfa0

@dacbd dacbd requested a review from 0x2b3bfa0 March 29, 2023 15:02
@0x2b3bfa0 0x2b3bfa0 merged commit 00d55e3 into iterative:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants