Fix leo read error for delete #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the delete wasn't syncing back data because of the read:
terraform-provider-iterative/task/aws/task.go
Line 248 in f84401c
it would try to check the Image, fail because it was not set, and then bailout from the read and continue to delete resources.
I don't think this should be the permanent solution. I think we should either use smaller parts on the existing interfaces to leo doesn't make unneeded API calls (instead of blank read for the whole task), or have a leo shutdown/close that is better suited for this (natural ending of a task syncing changes) and save delete for cleaning up broken tasks
Closes: #712