Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add structure for hardcoded credentials #710

Merged
merged 3 commits into from
Nov 7, 2022

Conversation

0x2b3bfa0
Copy link
Member

To be merged against #708

@0x2b3bfa0 0x2b3bfa0 added the enhancement New feature or request label Nov 4, 2022
@0x2b3bfa0 0x2b3bfa0 requested a review from tasdomas November 4, 2022 16:39
@0x2b3bfa0 0x2b3bfa0 self-assigned this Nov 4, 2022
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic November 4, 2022 16:39 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic November 4, 2022 16:39 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic November 4, 2022 16:39 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic November 4, 2022 16:39 Inactive
@0x2b3bfa0 0x2b3bfa0 added the cloud-common Applies to every cloud vendor label Nov 4, 2022
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic November 5, 2022 11:07 Inactive
@0x2b3bfa0 0x2b3bfa0 requested a deployment to automatic November 5, 2022 11:07 Abandoned
@0x2b3bfa0 0x2b3bfa0 requested a deployment to automatic November 5, 2022 11:07 Abandoned
@0x2b3bfa0 0x2b3bfa0 requested a deployment to automatic November 5, 2022 11:07 Abandoned
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic November 5, 2022 11:07 Inactive
@0x2b3bfa0 0x2b3bfa0 marked this pull request as ready for review November 5, 2022 16:38
@0x2b3bfa0 0x2b3bfa0 force-pushed the d025-server-start-credentials branch from 10dd59e to 2013975 Compare November 7, 2022 11:47
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic November 7, 2022 11:47 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic November 7, 2022 11:47 Inactive
@0x2b3bfa0 0x2b3bfa0 changed the base branch from d025-server-start to feature-leo-server November 7, 2022 11:47
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic November 7, 2022 11:47 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic November 7, 2022 11:47 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic November 7, 2022 11:47 Inactive
Copy link
Contributor

@tasdomas tasdomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix that use of anonymous members and this is good to go.

task/common/cloud.go Outdated Show resolved Hide resolved
@tasdomas tasdomas changed the base branch from feature-leo-server to d025-server-start November 7, 2022 12:24
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic November 7, 2022 12:26 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic November 7, 2022 12:26 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic November 7, 2022 12:26 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic November 7, 2022 12:26 Inactive
@0x2b3bfa0 0x2b3bfa0 requested a review from tasdomas November 7, 2022 12:27
@0x2b3bfa0 0x2b3bfa0 merged commit 60dbfc5 into d025-server-start Nov 7, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the d025-server-start-credentials branch November 7, 2022 12:42
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic November 7, 2022 12:45 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic November 7, 2022 12:45 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic November 7, 2022 12:45 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic November 7, 2022 12:45 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic November 7, 2022 12:45 Inactive
tasdomas added a commit that referenced this pull request Nov 7, 2022
* Server handler

* Add structure for hardcoded credentials (#710)

Co-authored-by: Helio Machado <0x2b3bfa0+git@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cloud-common Applies to every cloud vendor enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants