Improve comment #706
Improve comment #706
Conversation
iterative/utils/analytics.go
Outdated
| @@ -349,7 +349,7 @@ func JitsuEventPayload(action string, e error, extra map[string]interface{}) (ma | |||
| } | |||
|
|
|||
| if e != nil { | |||
| // Get the type of the error as a string, but not the error message itself, because it can be sensitive. | |||
| // Only use error type (not message) to avoid potentially sensitive information. | |||
There was a problem hiding this comment.
lol
| // Only use error type (not message) to avoid potentially sensitive information. | |
| // Only use error type (not message) to avoid potentially sensitive information |
There was a problem hiding this comment.
There was a problem hiding this comment.
Feel free to revert 🙈.
I'm not siding with you, and I don't like it, but I am happily caving in to the concept of an official spec.
Do you like my full sentences?
There was a problem hiding this comment.
Feel free to revert
Thanks! It's not worth the hassle to my mind, but appreciate it anyway. 🙏🏼
I'm not siding with you, and I don't like it, but I am happily caving in to the concept of an official spec. Do you like my full sentences?
This “rule” is quite flexible and not everybody follows it, less yet for inline code comments; it's mostly meant to document declarations. It's just one of those acquired tastes that some Gophers develop over time. 🦦
See e.g. the Go source code for examples.
Thanks for bringing a bit of elegance to code comments, @casperdcl! #704 (comment)