Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom machine+gpu*count on runner cloud=gcp #380

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Allow custom machine+gpu*count on runner cloud=gcp #380

merged 1 commit into from
Feb 2, 2022

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Feb 2, 2022 •
edited
Loading

This pull request allows iterative_machine and iterative_cml_runner users to specify custom machine+accelerator*count combinations (e.g. custom-8-53248+nvidia-tesla-k80*1) with the same syntax as the iterative_task resource. (Discord)

@0x2b3bfa0 0x2b3bfa0 requested a review from a team February 2, 2022 14:34
@0x2b3bfa0 0x2b3bfa0 self-assigned this Feb 2, 2022
@0x2b3bfa0 0x2b3bfa0 added cloud-gcp Google Cloud resource-machine iterative_machine TF resource resource-runner iterative_runner TF resource enhancement New feature or request labels Feb 2, 2022
casperdcl
casperdcl approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://go.dev/play/p/xACZHelxLMO :shipit:

@casperdcl casperdcl merged commit 610c449 into master Feb 2, 2022
@casperdcl casperdcl deleted the machine-runner-gcp-instance-gpu branch February 2, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperdcl casperdcl casperdcl approved these changes

Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
cloud-gcp Google Cloud enhancement New feature or request resource-machine iterative_machine TF resource resource-runner iterative_runner TF resource
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x2b3bfa0 @casperdcl