-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: get rid of setup.py/setup.cfg #447
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And misc maintenace updates: * Move all of the configs to pyproject.toml instead of 3 config. * Remove isort/black/flake8 in favor of ruff * Use local mypy hook instead of mirrors-mypy, as it hides a lot of errors. * Changes line-length to 88 (default in ruff). Luckily, this did not change any diff. * Add support for Python 3.12, and run tests in CI for 3.12.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #447 +/- ##
=======================================
Coverage 85.37% 85.37%
=======================================
Files 19 19
Lines 2120 2120
=======================================
Hits 1810 1810
Misses 310 310 ☔ View full report in Codecov by Sentry. |
shcheklein
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @skshetry , great update!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And misc maintenace updates:
dev
dependency extra.The
ruff
rules are equivalent to flake8. We can expand them in a separate PR if needed.Also, I haven't removed pylint. If we expand
ruff
rules, we can get rid ofpylint
.But that can be done in the next PR as my goal with this PR is to get rid of
setup.py
/setup.cfg
.