Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: get rid of setup.py/setup.cfg #447

Merged
merged 4 commits into from
Mar 25, 2024
Merged

chore: get rid of setup.py/setup.cfg #447

merged 4 commits into from
Mar 25, 2024

Conversation

skshetry
Copy link
Member

And misc maintenace updates:

  • Move all of the configs to pyproject.toml instead of 3 config.
  • Remove isort/black/flake8 in favor of ruff
  • Use local mypy hook instead of mirrors-mypy, as it hides a lot of errors.
  • Changes line-length to 88 (default in ruff). Luckily, this did not change any diff.
  • Add support for Python 3.12, and run tests in CI for 3.12.
  • Introduce dev dependency extra.

The ruff rules are equivalent to flake8. We can expand them in a separate PR if needed.
Also, I haven't removed pylint. If we expand ruff rules, we can get rid of pylint.
But that can be done in the next PR as my goal with this PR is to get rid of setup.py/setup.cfg.

And misc maintenace updates:

* Move all of the configs to pyproject.toml instead of 3 config.
* Remove isort/black/flake8 in favor of ruff
* Use local mypy hook instead of mirrors-mypy, as it hides a lot of errors.
* Changes line-length to 88 (default in ruff). Luckily, this did not change any diff.
* Add support for Python 3.12, and run tests in CI for 3.12.
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.37%. Comparing base (d4852de) to head (69dcd12).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #447   +/-   ##
=======================================
  Coverage   85.37%   85.37%           
=======================================
  Files          19       19           
  Lines        2120     2120           
=======================================
  Hits         1810     1810           
  Misses        310      310           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @skshetry , great update!

@skshetry skshetry merged commit 9ebabbf into main Mar 25, 2024
17 checks passed
@skshetry skshetry deleted the misc-updates branch March 25, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants