Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use markdown for notebook reports #558

Merged
merged 5 commits into from
May 15, 2023
Merged

use markdown for notebook reports #558

merged 5 commits into from
May 15, 2023

Conversation

dberenbaum
Copy link
Collaborator

@dberenbaum dberenbaum commented May 5, 2023

Fixes #537 and #546

Depends on iterative/dvc-render#129.

Screen.Recording.2023-05-05.at.4.15.17.PM.mov

Still needs:

  • dependency on updated dvc-render
  • tests
  • cleanup image support

@dberenbaum dberenbaum requested a review from daavoo May 5, 2023 20:25
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.09 ⚠️

Comparison is base (29b95c3) 95.88% compared to head (5c98c3f) 95.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #558      +/-   ##
==========================================
- Coverage   95.88%   95.79%   -0.09%     
==========================================
  Files          43       43              
  Lines        2744     2735       -9     
  Branches      236      233       -3     
==========================================
- Hits         2631     2620      -11     
- Misses         66       69       +3     
+ Partials       47       46       -1     
Impacted Files Coverage Δ
src/dvclive/live.py 91.18% <100.00%> (ø)
src/dvclive/report.py 96.03% <100.00%> (+1.64%) ⬆️
tests/test_report.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@daavoo daavoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This renders nicer and looks cleaner in the code 🚀

@dberenbaum
Copy link
Collaborator Author

Updated to render without creating any persistent markdown file

@dberenbaum dberenbaum marked this pull request as ready for review May 15, 2023 18:01
@dberenbaum dberenbaum requested a review from daavoo May 15, 2023 18:01
@dberenbaum dberenbaum merged commit b67a2c5 into main May 15, 2023
@dberenbaum dberenbaum deleted the md-notebook branch May 15, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notebook report generates 404 if running multiple experiments
3 participants