Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use setuptools_scm #278

Closed
wants to merge 1 commit into from
Closed

Conversation

dtrifiro
Copy link
Contributor

No description provided.

@dtrifiro dtrifiro requested review from pared and daavoo August 31, 2022 16:33
@skshetry
Copy link
Member

@dtrifiro, I propose migrating to py-template straight away. Let me know if you need any help, I did that last week with scmrepo.

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2022

Codecov Report

Base: 90.67% // Head: 91.38% // Increases project coverage by +0.70% 🎉

Coverage data is based on head (d06f8bb) compared to base (086659f).
Patch coverage: 60.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
+ Coverage   90.67%   91.38%   +0.70%     
==========================================
  Files          21       21              
  Lines         751      720      -31     
==========================================
- Hits          681      658      -23     
+ Misses         70       62       -8     
Impacted Files Coverage Δ
dvclive/version.py 60.00% <60.00%> (-12.23%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skshetry
Copy link
Member

Related: #272

@dtrifiro
Copy link
Contributor Author

dtrifiro commented Aug 31, 2022

@dtrifiro, I propose migrating to py-template straight away. Let me know if you need any help, I did that last week with scmrepo.

Yeah, I think it's worth it.

@dtrifiro
Copy link
Contributor Author

dtrifiro commented Sep 1, 2022

Superseded by #281

@dtrifiro dtrifiro closed this Sep 1, 2022
@dtrifiro dtrifiro deleted the use-setuptools-scm branch September 1, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants