plots: upgrade to latest Vega library versions #6371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related: #6218 as noted in that issue, if you need specific features you can define your own HTML template to override vega-lite version used in the default DVC templates |
|
@pmrowla Thanks for the suggestion, that's exactly what I'm doing right now. |
pared
approved these changes
Aug 2, 2021
|
@arjvik can you rebase on current master? |
|
@pared done! |
|
@pared Seems like both automated and manual tests have passed... is this going to get merged? |
|
@arjvik sorry for the delay, yes I think we can merge it. |
|
Hi @pared should we do a super quick update to the example in https://dvc.org/doc/command-reference/plots#example-offline-html-template ? Also, that should be an H2 😁 (it's an H3 rn). Thanks |
|
@jorgeorpinel lets continue in iterative/dvc.org#2798 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
[N/A] 📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
The current version of Vega included in the plots template page is quite outdated. Many of the features mentioned in the Vega Lite documentation are Vega-Lite 5.0 only, and thus fail to work on the 4.0 version included by DVC. I submitted this change that simply changes the version numbers to the latest versions released as of now.
One idea to consider is omitting the version entirely and allowing jsDelivr to pick the latest version it has available. Vega plots all require a
$schemaparameter that specifies the version of the Vega specification to adhere to when displaying, so even breaking changes to the latest spec should not cause issues to existing plots.