push params in the experiments table to the right #6254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
added
A: experiments
|
I think your original code is right. Metrics are right-aligned and params are left-aligned to match the viewer behavior. For the columns where metrics & params meet, the right-most metric and left-most param values are supposed to appear directly adjacent to one another.
|
Metric columns are still broken then, as they are left aligned. |
Made a mistake during refactoring on styling before
skshetry
force-pushed
the
push-params-right
branch
from
a3fb240 to
099315b
Compare
pmrowla
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a mistake during refactoring on styling before. Noticed while reviewing #6174.
Before
After
paramsas justify.