Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates: Add optional fs arg. #96

Merged
merged 1 commit into from
Nov 15, 2022
Merged

templates: Add optional fs arg. #96

merged 1 commit into from
Nov 15, 2022

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Nov 15, 2022

Replace rglob with exact matching. Fixes potential bug from using rglob({template_name}*)

Per https://github.com/iterative/studio/pull/4504

@daavoo daavoo force-pushed the get-template-f branch 2 times, most recently from 7472f92 to 3305982 Compare November 15, 2022 09:33
Replace `rglob` with exatch matching. Fixes potential bug from using `rglob({template_name}*)`

Per https://github.com/iterative/studio/pull/4504
Copy link

@amritghimire amritghimire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@amritghimire
Copy link

Tested it by replacing in https://github.com/iterative/studio/pull/4504, Works perfectly. Thanks !

@daavoo daavoo merged commit 841584e into main Nov 15, 2022
@daavoo daavoo deleted the get-template-f branch November 15, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants