Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vega: Escape special characters in field and title. #81

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Sep 6, 2022

Closes #80

@daavoo daavoo requested a review from pared September 6, 2022 08:25
@daavoo daavoo self-assigned this Sep 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2022

Codecov Report

Base: 95.79% // Head: 95.91% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (5731117) compared to base (c6f6abc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   95.79%   95.91%   +0.12%     
==========================================
  Files          19       19              
  Lines         642      661      +19     
  Branches      119      121       +2     
==========================================
+ Hits          615      634      +19     
  Misses         22       22              
  Partials        5        5              
Impacted Files Coverage Δ
src/dvc_render/vega.py 97.29% <100.00%> (+0.03%) ⬆️
src/dvc_render/vega_templates.py 98.16% <100.00%> (+0.08%) ⬆️
tests/test_templates.py 100.00% <100.00%> (ø)
tests/test_vega.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daavoo daavoo merged commit b4dbe1c into main Sep 6, 2022
@daavoo daavoo deleted the escape-special-characters branch September 6, 2022 11:26
daavoo added a commit that referenced this pull request Sep 15, 2022
Unnecesary escaping for `title` and labels was added in #81.
@daavoo daavoo mentioned this pull request Sep 15, 2022
daavoo added a commit that referenced this pull request Sep 15, 2022
Unnecesary escaping for `title` and labels was added in #81.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vega: Escape special characters (.[]) in field
3 participants