Upgrade vega-lite to 5.2.0 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #51 +/- ##
=======================================
Coverage 95.80% 95.80%
=======================================
Files 14 14
Lines 477 477
Branches 77 77
=======================================
Hits 457 457
Misses 15 15
Partials 5 5
Continue to review full report at Codecov.
|
|
Tested on https://github.com/iterative/example-get-started, all current plots work as intended. |
pared
approved these changes
Jun 9, 2022
|
Thank you @daniel-falk for the PR and sorry for getting to it so late. 🙏 |
|
Hi, That's nice! I have verified that my bar plot works with DVC and DVC-render from the main branch now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I wanted to create bar-plots for DVC and to be able to diff these I use the xOffset parameter in vega-lite. This was added in the 5.2.0 release of vega-lite.
For an example of the bar plots, see: https://github.com/daniel-falk/dvc-examples
I am not sure how to build DVC with this updated version of dvc-render, so I have not tested it other than with the custom html template in the repo linked above.