Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vega: templates: make confusion matrix interactive #45

Merged
merged 1 commit into from
May 17, 2022

Conversation

pared
Copy link
Contributor

@pared pared commented May 10, 2022

Introducing interactivity to confusion matrix.
example
(hover over confusion matrix to see the effect).

Ideally we would also like to have ability to see number of actual vs number of predicted when hovering over it.
I will play around with this PR and see how hard that can be. If i wont find quick solution, I will create issue for that.

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2022

Codecov Report

Merging #45 (46dc455) into main (28c1495) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   95.68%   95.68%           
=======================================
  Files          14       14           
  Lines         464      464           
  Branches       76       76           
=======================================
  Hits          444      444           
  Misses         15       15           
  Partials        5        5           
Impacted Files Coverage Δ
src/dvc_render/vega_templates.py 97.95% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28c1495...46dc455. Read the comment docs.

@shcheklein
Copy link
Member

@pared looks good, thanks. Tooltip with actual numbers would be great to have!

@pared
Copy link
Contributor Author

pared commented May 11, 2022

@shcheklein my bad, what I was discussing with @mnrozhkov was to show a tooltip with actual {class} and predicted {class}. Added the tooltip.
After the modification the confusion matrix will look as follows
Anyway, we can add other fields too.

@mnrozhkov
Copy link

Tooltip with actual numbers would be great to have!

Thanks @pared ! Looks good for me! It's very helpful for matrix with many classes!
@shcheklein usually confusion matrix contains numbers of classes in each cell (not ratio). So,Tooltip with actual numbers is not necessary.

@pared
Copy link
Contributor Author

pared commented May 11, 2022

@mnrozhkov I think the confusion started from me not understanding our discussion, only reading it today made me realize what you need :)

@pared pared merged commit a9c404d into iterative:main May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants