Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groupby mean #151

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Groupby mean #151

merged 1 commit into from
Jan 23, 2024

Conversation

dberenbaum
Copy link
Contributor

@dberenbaum dberenbaum commented Jan 22, 2024

See https://github.com/iterative/studio/issues/8851

Averages over groupby instead of summing, so that if there are multiple values within each group, we don't end up with unexpectedly large values (for example, >1 values in an ROC plot).

Before this PR:

Screen.Recording.2024-01-22.at.5.23.52.PM.mov

After this PR:

Screen.Recording.2024-01-22.at.5.24.09.PM.mov

@mattseddon mattseddon marked this pull request as ready for review January 22, 2024 23:17
@mattseddon mattseddon self-requested a review January 22, 2024 23:17
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (012111f) 97.63% compared to head (a6b078f) 97.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
+ Coverage   97.63%   97.65%   +0.01%     
==========================================
  Files          19       19              
  Lines        1058     1064       +6     
  Branches      169      169              
==========================================
+ Hits         1033     1039       +6     
  Misses         15       15              
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattseddon mattseddon merged commit 7215e84 into main Jan 23, 2024
13 checks passed
@mattseddon mattseddon deleted the groupby-mean branch January 23, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants