Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for data anchor to be found in list #133

Merged
merged 1 commit into from
May 17, 2023
Merged

allow for data anchor to be found in list #133

merged 1 commit into from
May 17, 2023

Conversation

dberenbaum
Copy link
Contributor

Before this PR, if I include the <DVC_METRIC_DATA> anchor in a custom template within a list, I would get this:

$ dvc plots show
ERROR: unexpected error - Template 'vega_linear.json' is not using '<DVC_METRIC_DATA>' anchor

Found this when trying out a vega (not vega-lite) template. Even though we don't support vega, it still seems like a bug, and vega actually works after this PR, at least for the simple example I tried.

@dberenbaum dberenbaum requested a review from daavoo May 16, 2023 21:31
@daavoo daavoo merged commit 635eaff into main May 17, 2023
@daavoo daavoo deleted the val-data-anchor branch May 17, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants