Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Option to stop blinds #483

Closed
1HyperZ opened this issue Jul 13, 2022 · 17 comments
Closed

[Feature] Option to stop blinds #483

1HyperZ opened this issue Jul 13, 2022 · 17 comments
Assignees
Labels
enhancement New feature or request

Comments

@1HyperZ
Copy link

1HyperZ commented Jul 13, 2022

Please use the template and fill in all the data requested below!

Describe the bug
when you click on blinds in the home app it opens or close doesnt stop

Related devices
Are you experiencing this behavior with a particular device?
Please list which device(s) you experience this with.

To Reproduce
Steps to reproduce the behavior, for example:

  1. Change '...' via the Home app.
  2. Log shows MQTT message '...' being published to topic '...'
  3. The device does the following: '...'

Expected behavior
i expect that after you press open the next press will be stop not close

MQTT messages
If possible (and applicable), please provide the following:

  • The device entry from zigbee2mqtt/bridge/devices (note: this is different from zigbee2mqtt/bridge/config/devices)
  • Status update from zigbee2mqtt/[FRIENDLY_NAME]
  • Messages published by this plugin that might be related to your issue (can also be seen in the homebridge logs)

Versions used
Please provide the version of the following pieces of software:

  • This plugin
  • Homebridge
  • Zigbee2MQTT (can be found in MQTT topic zigbee2mqtt/bridge/info)
  • Homebridge Config UI X (if applicable)
@1HyperZ 1HyperZ added the bug Something isn't working label Jul 13, 2022
@itavero
Copy link
Owner

itavero commented Jul 13, 2022

Did you set the limits of the cover on the device itself?

FYI: Open and close always means 0% or 100% in HomeKit.
You need to set a percentage if you want a level in between (e.g. by pressing down on the tile in the Home.app rather then tapping it, similar to changing the brightness of a bulb).

@1HyperZ
Copy link
Author

1HyperZ commented Jul 13, 2022

i recently changed from shelly 2.5 to this module on the shelly i could just tap it on the room screen and it would up/stop/down the blinds why is it different?

@itavero
Copy link
Owner

itavero commented Jul 13, 2022

I'm unaware of that feature.
This plugin implements all required characteristics of a Window Covering as far as I'm aware.

Perhaps an additional characteristic can provide this.
If you can tell me what characteristic you'd need and how it should be mapped, we can turn this issue into a feature request.

@1HyperZ
Copy link
Author

1HyperZ commented Jul 13, 2022

i dont really know how it should be mapped or anything like that but i think its the Hold Position characteristic that does that. if it helps i can take a video of how it looks in the home app when using this plugin and how it looks when using a shelly for example

@itavero
Copy link
Owner

itavero commented Jul 14, 2022

That won't really help. Do you know of an open source plugin/firmware that implements this feature?

@1HyperZ
Copy link
Author

1HyperZ commented Jul 14, 2022

That won't really help. Do you know of an open source plugin/firmware that implements this feature?

I know the Shelly HomeKit firmware use it for sure( Shelly doesn't natively support HomeKit you need to update to a custom firmware) here i would send a link to there GitHub https://github.com/mongoose-os-apps/shelly-homekit

@itavero
Copy link
Owner

itavero commented Jul 18, 2022

The Hold Position characteristic is indeed mentioned in their code, but I'm not that familiair with their code base to see if this is the characteristic that gets you this behavior: https://github.com/mongoose-os-apps/shelly-homekit/blob/8b48fba899d3c17d9347d12efee085d31743a921/src/shelly_hap_window_covering.cpp

@itavero itavero added enhancement New feature or request and removed bug Something isn't working labels Jul 18, 2022
@itavero itavero changed the title [Bug] There is no option to stop the blinds [Feature] Option to stop blinds Jul 18, 2022
@1HyperZ
Copy link
Author

1HyperZ commented Jul 18, 2022

The Hold Position characteristic is indeed mentioned in their code, but I'm not that familiair with their code base to see if this is the characteristic that gets you this behavior: https://github.com/mongoose-os-apps/shelly-homekit/blob/8b48fba899d3c17d9347d12efee085d31743a921/src/shelly_hap_window_covering.cpp

Ok thank you anyways

@stale
Copy link

stale bot commented Aug 31, 2022

It appears that this issue did not have an update in quite some time. Please check if you can provide any additional information to help resolve this issue. If there isn't any activity in the next two weeks, this issue will be closed automatically. Thank you for your contributions!

@stale stale bot added the stale label Aug 31, 2022
@stale stale bot closed this as completed Sep 15, 2022
@itavero itavero reopened this Sep 30, 2022
@stale stale bot removed the stale label Sep 30, 2022
@itavero itavero self-assigned this Sep 30, 2022
@itavero
Copy link
Owner

itavero commented Sep 30, 2022

Finally had some time to look into this. I think I've made an implementation that can work, based on what I've seen in the Shelly repository.
However, it's totally unclear to me how to trigger this "Stop" action via HomeKit.

@1HyperZ Can you tell me where I can find this in the Home.app on iOS 16? I really want to see it working before merging and releasing it.

@1HyperZ
Copy link
Author

1HyperZ commented Sep 30, 2022

In iOS 15 you would trigger this just by pressing on the accessory's icon on the rooms screen in iOS 16 you would click on the icon as well but you need to press on the center of the icon and not on the side because it will pull up the setting for the accessory see in photoimage

@itavero
Copy link
Owner

itavero commented Oct 1, 2022

Thanks for the information. I still wasn't able to trigger this through the Home.app on iOS 16.

I did check the Eve app and noticed that it now shows a Stop button (after implementing the Hold Position characteristic) which it did not have before.
image

This allows you to stop at the current position, after which the actual position will be update in a short moment.

I'll go ahead and try to include it in the next release.

@1HyperZ
Copy link
Author

1HyperZ commented Nov 17, 2022

I can't find this stop option even in the eve app🤷‍♂️image

@itavero
Copy link
Owner

itavero commented Nov 17, 2022

Did I already release this? 🤔
During development, I only could stop it from the Home app when it's "moving" in the app as well.

@1HyperZ
Copy link
Author

1HyperZ commented Nov 17, 2022

Oh didn't know you haven't released it yet let me know when you do and thank you

@itavero
Copy link
Owner

itavero commented Dec 9, 2022

Just release v1.10.0 to homebridge-z2m@next. Because there were quite some internal changes, I haven't pushed it to latest yet. So far it seems to be working fine on my setup, but if you run into any issues, please do let me know.

@itavero
Copy link
Owner

itavero commented Dec 9, 2022

Just released v1.10.0 to homebridge-z2m@next which includes this feature. Because there were quite some internal changes, I haven't pushed it to latest yet. So far it seems to be working fine on my setup, but if you run into any issues, please do let me know.

@itavero itavero closed this as completed Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants