Improve test 30 and test 31 descriptions #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The descriptions of test 30 and 31 should better specify that the checked issuer is the Response one, in contrast with the Assertion issuer checked by tests 71 and 72, in particular because the expected result of test 31 is different from that of test 71 due to some discrepancy in SPID specification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The descriptions of test 30 and 31 should better specify that the checked issuer is the Response one, in contrast with the Assertion issuer checked by tests 71 and 72, in particular because the expected result of test 31 is different from that of test 71 due to some discrepancy in SPID specification.
Closes #73.