feat: check cookies per pagine di eventi

italia · Feb 6, 2023 · 1496ffd · 1496ffd
1 parent 60e02e6
commit 1496ffd
Show file tree

Hide file tree

Showing 11 changed files with 153 additions and 95 deletions.
diff --git a/src/audits/municipality/bookingAppointmentAudit.ts b/src/audits/municipality/bookingAppointmentAudit.ts
@@ -3,7 +3,10 @@
 // @ts-ignore
 import lighthouse from "lighthouse";
 import { loadPageData } from "../../utils/utils";
-import { getRandomMunicipalityThirdLevelPagesUrl } from "../../utils/municipality/utils";
+import {
+  getRandomMunicipalityThirdLevelPagesUrl,
+  getServicePageUrl,
+} from "../../utils/municipality/utils";
 import { auditDictionary } from "../../storage/auditDictionary";
 
 const Audit = lighthouse.Audit;
@@ -48,6 +51,7 @@ class LoadAudit extends Audit {
     const randomServices: string[] =
       await getRandomMunicipalityThirdLevelPagesUrl(
         url,
+        await getServicePageUrl(url),
         '[data-element="service-link"]'
       );
 

diff --git a/src/audits/municipality/bootstrapItaliaDoubleCheckAudit.ts b/src/audits/municipality/bootstrapItaliaDoubleCheckAudit.ts
@@ -15,6 +15,7 @@ import {
   getRandomMunicipalityFirstLevelPagesUrl,
   getRandomMunicipalitySecondLevelPagesUrl,
   getRandomMunicipalityThirdLevelPagesUrl,
+  getServicePageUrl,
 } from "../../utils/municipality/utils";
 import { auditScanVariables } from "../../storage/municipality/auditScanVariables";
 import { cssClasses } from "../../storage/municipality/cssClasses";
@@ -102,6 +103,7 @@ class LoadAudit extends Audit {
       )),
       ...(await getRandomMunicipalityThirdLevelPagesUrl(
         url,
+        await getServicePageUrl(url),
         '[data-element="service-link"]',
         auditVariables.numberOfServicesToBeScanned
       )),

diff --git a/src/audits/municipality/contactsAssistencyAudit.ts b/src/audits/municipality/contactsAssistencyAudit.ts
@@ -3,7 +3,10 @@
 // @ts-ignore
 import lighthouse from "lighthouse";
 import { getPageElementDataAttribute, loadPageData } from "../../utils/utils";
-import { getRandomMunicipalityThirdLevelPagesUrl } from "../../utils/municipality/utils";
+import {
+  getRandomMunicipalityThirdLevelPagesUrl,
+  getServicePageUrl,
+} from "../../utils/municipality/utils";
 import { CheerioAPI } from "cheerio";
 import { auditDictionary } from "../../storage/auditDictionary";
 
@@ -59,6 +62,7 @@ class LoadAudit extends Audit {
     const randomServices: string[] =
       await getRandomMunicipalityThirdLevelPagesUrl(
         url,
+        await getServicePageUrl(url),
         '[data-element="service-link"]'
       );
 

diff --git a/src/audits/municipality/cookieDomainCheckAudit.ts b/src/audits/municipality/cookieDomainCheckAudit.ts
@@ -11,8 +11,10 @@ import {
   getRandomMunicipalityFirstLevelPagesUrl,
   getRandomMunicipalitySecondLevelPagesUrl,
   getRandomMunicipalityThirdLevelPagesUrl,
+  getServicePageUrl,
 } from "../../utils/municipality/utils";
 import { auditScanVariables } from "../../storage/municipality/auditScanVariables";
+import { getButtonUrl, loadPageData } from "../../utils/utils";
 
 const Audit = lighthouse.Audit;
 
@@ -84,11 +86,17 @@ class LoadAudit extends Audit {
       )),
       ...(await getRandomMunicipalityThirdLevelPagesUrl(
         url,
+        await getServicePageUrl(url),
         '[data-element="service-link"]',
         auditVariables.numberOfServicesToBeScanned
       )),
       ...(await getRandomMunicipalityThirdLevelPagesUrl(
         url,
+        await getButtonUrl(
+          await loadPageData(url),
+          url,
+          `[data-element="live-button-events"]`
+        ),
         '[data-element="event-link"]',
         auditVariables.numberOfEventsToBeScanned
       )),

diff --git a/src/audits/municipality/fontsCheckAudit.ts b/src/audits/municipality/fontsCheckAudit.ts
@@ -3,7 +3,10 @@
 // @ts-ignore
 import lighthouse from "lighthouse";
 import { allowedFonts } from "../../storage/municipality/allowedFonts";
-import { getRandomMunicipalityThirdLevelPagesUrl } from "../../utils/municipality/utils";
+import {
+  getRandomMunicipalityThirdLevelPagesUrl,
+  getServicePageUrl,
+} from "../../utils/municipality/utils";
 import puppeteer from "puppeteer";
 import { auditDictionary } from "../../storage/auditDictionary";
 
@@ -52,6 +55,7 @@ class LoadAudit extends Audit {
     const randomServices: string[] =
       await getRandomMunicipalityThirdLevelPagesUrl(
         url,
+        await getServicePageUrl(url),
         '[data-element="service-link"]'
       );
 

diff --git a/src/audits/municipality/metatagAudit.ts b/src/audits/municipality/metatagAudit.ts
@@ -3,7 +3,10 @@
 // @ts-ignore
 import lighthouse from "lighthouse";
 import { loadPageData } from "../../utils/utils";
-import { getRandomMunicipalityThirdLevelPagesUrl } from "../../utils/municipality/utils";
+import {
+  getRandomMunicipalityThirdLevelPagesUrl,
+  getServicePageUrl,
+} from "../../utils/municipality/utils";
 import { CheerioAPI } from "cheerio";
 import { ValidatorResult } from "jsonschema";
 import * as jsonschema from "jsonschema";
@@ -64,6 +67,7 @@ class LoadAudit extends Audit {
     const randomServices: string[] =
       await getRandomMunicipalityThirdLevelPagesUrl(
         url,
+        await getServicePageUrl(url),
         '[data-element="service-link"]'
       );
 

diff --git a/src/audits/municipality/secondLevelPagesAudit.ts b/src/audits/municipality/secondLevelPagesAudit.ts
@@ -5,6 +5,7 @@
 import lighthouse from "lighthouse";
 import {
   buildUrl,
+  getButtonUrl,
   getHREFValuesDataAttribute,
   getPageElementDataAttribute,
   loadPageData,
@@ -105,7 +106,7 @@ class LoadAudit extends lighthouse.Audit {
       }
 
       $ = await loadPageData(secondLevelPageUrl);
-      const secondaryMenuDataElement = `[data-element="${primaryMenuItem.secondary_item_data_element}"]`;
+      const secondaryMenuDataElement = `[data-element="${primaryMenuItem.secondary_item_data_element[0]}"]`;
       let secondLevelPagesNames = [];
 
       if (key !== "live" && primaryMenuItem.dictionary.length > 0) {
@@ -114,27 +115,14 @@ class LoadAudit extends lighthouse.Audit {
           secondaryMenuDataElement
         );
       } else {
-        const buttons = $(secondaryMenuDataElement);
-        for (const button of buttons) {
-          const elementObj = $(button).attr();
-          if (
-            elementObj !== null &&
-            elementObj !== undefined &&
-            "onclick" in elementObj &&
-            elementObj.onclick.includes("location.href")
-          ) {
-            const onClick: string = elementObj.onclick;
-            let secondPageLink = onClick.substring(
-              onClick.indexOf("'") + 1,
-              onClick.lastIndexOf("'")
-            );
-            if (!secondPageLink.includes(url)) {
-              secondPageLink = await buildUrl(url, secondPageLink);
-            }
+        for (const dataElement of primaryMenuItem.secondary_item_data_element) {
+          const buttonDataElement = `[data-element="${dataElement}"]`;
+          const pageLinkUrl = await getButtonUrl($, url, buttonDataElement);
 
-            $ = await loadPageData(secondPageLink);
+          if (pageLinkUrl.length > 0) {
+            const $2 = await loadPageData(pageLinkUrl);
             secondLevelPagesNames.push(
-              $('[data-element="page-name"]').text().trim() ?? ""
+              $2('[data-element="page-name"]').text().trim() ?? ""
             );
           }
         }

diff --git a/src/audits/municipality/serviziAudit.ts b/src/audits/municipality/serviziAudit.ts
@@ -12,7 +12,10 @@ import {
   missingMenuItems,
   toMenuItem,
 } from "../../utils/utils";
-import { getRandomMunicipalityThirdLevelPagesUrl } from "../../utils/municipality/utils";
+import {
+  getRandomMunicipalityThirdLevelPagesUrl,
+  getServicePageUrl,
+} from "../../utils/municipality/utils";
 import {
   contentTypeItemsBody,
   contentTypeItemsHeaders,
@@ -88,6 +91,7 @@ class LoadAudit extends Audit {
     const randomServices: string[] =
       await getRandomMunicipalityThirdLevelPagesUrl(
         url,
+        await getServicePageUrl(url),
         '[data-element="service-link"]',
         auditVariables.numberOfServicesToBeScanned
       );

diff --git a/src/storage/municipality/menuItems.ts b/src/storage/municipality/menuItems.ts
@@ -4,7 +4,7 @@ export const primaryMenuItems = {
     name: "Amministrazione",
     regExp: /^Amministrazione$/i,
     data_element: "management",
-    secondary_item_data_element: "management-category-link",
+    secondary_item_data_element: ["management-category-link"],
     dictionary: [
       "aree amministrative",
       "documenti e dati",
@@ -20,15 +20,15 @@ export const primaryMenuItems = {
     name: "Novità",
     regExp: /^Novità$/i,
     data_element: "news",
-    secondary_item_data_element: "news-category-link",
+    secondary_item_data_element: ["news-category-link"],
     dictionary: ["avvisi", "comunicati", "notizie"],
   },
   services: {
     label: "SERVIZI",
     name: "Servizi",
     regExp: /^Servizi$/i,
     data_element: "all-services",
-    secondary_item_data_element: "service-category-link",
+    secondary_item_data_element: ["service-category-link"],
     dictionary: [
       "educazione e formazione",
       "salute, benessere e assistenza",
@@ -52,7 +52,10 @@ export const primaryMenuItems = {
     name: "Vivere [nome del Comune]",
     regExp: /^Vivere /i,
     data_element: "live",
-    secondary_item_data_element: "live-button",
+    secondary_item_data_element: [
+      "live-button-locations",
+      "live-button-events",
+    ],
     dictionary: ["luoghi", "eventi"],
   },
 };