Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Satosa][Bug] Incorrect QR code value in cross device flow #302

Closed
Zicchio opened this issue Nov 8, 2024 · 1 comment · Fixed by #304
Closed

[Satosa][Bug] Incorrect QR code value in cross device flow #302

Zicchio opened this issue Nov 8, 2024 · 1 comment · Fixed by #304
Assignees
Labels
bug Something isn't working

Comments

@Zicchio
Copy link
Collaborator

Zicchio commented Nov 8, 2024

The cross device flow containg a QR code with the wrong value: the link host is not satosa-pyeudiw itself but it should be the target wallet application.
This is the line of code with the incorrect behaviour

# Cross Device flow
res_url = f'{self.client_id}?{url_params}'
result = self.template.qrcode_page.render(

The QR code should be a deep-link/universal-link/whatever much like in the same device flow as otherwise the user would not be able to open the holder app.
In fact, it's the same link.

See
https://italia.github.io/eudi-wallet-it-docs/versione-corrente/en/relying-party-solution.html#authorization-request-details

@Zicchio Zicchio added the bug Something isn't working label Nov 8, 2024
@peppelinux
Copy link
Member

Confirmed, it must use the url configured here:

https://github.com/italia/eudi-wallet-it-python/blob/dev/example/satosa/pyeudiw_backend.yaml#L64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants