Revocation and Status Assertions flows reviewed #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppelinux
reviewed
Jun 8, 2024
peppelinux
requested changes
Jun 8, 2024
docs/en/revocation-lists.rst
Outdated
| "jti": "6f204f7e-e453-4dfd-814e-9d155319408c" | ||
| "credential_hash": $CREDENTIAL-HASH, | ||
| "credential_hash_alg": "sha-256", | ||
| "msg": "Revoked" |
There was a problem hiding this comment.
@SaraConsoliACN please, as discussed during our editor call, provide another parameter name with a good semantic
docs/en/revocation-lists.rst
Outdated
Comment on lines
644
to
646
| * - **msg** | ||
| - Message returned from the Credential Issuer after revocation. It MUST be set with the value "OK". | ||
| - This specification. |
There was a problem hiding this comment.
this msg is not defined in the status assertion draft.
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
peppelinux
reviewed
Jun 17, 2024
peppelinux
reviewed
Jun 17, 2024
peppelinux
reviewed
Jun 17, 2024
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
peppelinux
requested changes
Jun 17, 2024
docs/en/revocation-lists.rst
Outdated
| * - **credential_pop** | ||
| - It MUST contain a JWT proof of possession of the cryptographic key the Credential to be revoked shall be bound to. See Section :ref:`Credential Proof of Possession <sec_revocation_credential_pop>` for more details. | ||
| - `[OAuth Status Attestation draft 01] <https://datatracker.ietf.org/doc/draft-demarco-status-attestations/01/>`_ | ||
| * - **revocation_assertion_requests** |
There was a problem hiding this comment.
this parameter name must be changed
the scope of the request is to request the revocation of credentials or wallet instance attestations
There was a problem hiding this comment.
the parameter name is changed with revocation_requests
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
|
this PR must cover the wallet instance revocation request use case and the pid provider revocation request use case |
This was referenced Jun 18, 2024
peppelinux
requested changes
Jun 26, 2024
docs/en/revocation-lists.rst
Outdated
| "jti": "6f204f7e-e453-4dfd-814e-9d155319408c" | ||
| "credential_hash": $CREDENTIAL-HASH, | ||
| "credential_hash_alg": "sha-256", | ||
| "msg": "Revoked" |
There was a problem hiding this comment.
@SaraConsoliACN please, as discussed during our editor call, provide another parameter name with a good semantic
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
|
@peppelinux @SaraConsoliACN, I made last commits to align with the current draft of status assertion, as a note credential status validity is still in a PR and is not included in the draft 2 yet. |
m-basili
approved these changes
Jul 26, 2024
peppelinux
approved these changes
Jul 29, 2024
grausof
approved these changes
Jul 30, 2024
peppelinux
reviewed
Jul 30, 2024
peppelinux
reviewed
Jul 30, 2024
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
RFC 7519 reference retained only in the standards.rst file.
peppelinux
reviewed
Jul 30, 2024
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
peppelinux
reviewed
Jul 31, 2024
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
peppelinux
approved these changes
Jul 31, 2024
|
fixes #265 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Revocation and Status Attestation flows reviewed
Content
Content review based on the new version of the specifications defined in https://github.com/peppelinux/draft-demarco-oauth-status-attestations
resolve #265