-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Wallet Attestation request flow #233
Conversation
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Wallet Attestation and Solution chores
… endpoint pointing to SIOP
defind terms removea misleading element, wallet solution removed auth…
Co-authored-by: fmarino-ipzs <77629526+fmarino-ipzs@users.noreply.github.com>
Co-authored-by: fmarino-ipzs <77629526+fmarino-ipzs@users.noreply.github.com>
Co-authored-by: fmarino-ipzs <77629526+fmarino-ipzs@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR requires some changes regarding a the defined terms and the examples about the technologies that the WSCD may use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost done :-)
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my review, I suggest adding more details about the types of WSCDs that the wallet solution may implement.
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The LoA topic should be further discussed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
editorial
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
This PR introduces the flow of obtaining the Wallet Attestation using the Key Attestation and Integrity Check systems of Android and iOS through an abstraction called Device Integrity Service. This implementation allows you to securely obtain attestation and verify that the device has not been tampered with as well as ensures that the running application is genuine and the keys used are hardware backed.
This PR resolve: