Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relying Party #220

Merged
merged 15 commits into from
Mar 5, 2024
Merged

Relying Party #220

merged 15 commits into from
Mar 5, 2024

Conversation

peppelinux
Copy link
Member

Closes #185

This PR:

  • adds the WTE in the presentation definition
  • adds the normative base for the RP Entity Configuration
  • brings some editorial fixtures

@peppelinux peppelinux marked this pull request as draft March 1, 2024 11:51
@peppelinux peppelinux marked this pull request as ready for review March 1, 2024 13:43
giadas
giadas reviewed Mar 1, 2024
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
giadas
giadas reviewed Mar 1, 2024
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
giadas
giadas reviewed Mar 1, 2024
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
giadas
giadas reviewed Mar 1, 2024
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
giadas
giadas reviewed Mar 1, 2024
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
giadas
giadas reviewed Mar 1, 2024
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
giadas
giadas reviewed Mar 1, 2024
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
giadas
giadas reviewed Mar 1, 2024
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
giadas
giadas reviewed Mar 1, 2024
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
giadas
giadas reviewed Mar 1, 2024
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
giadas
giadas reviewed Mar 1, 2024
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
giadas
giadas reviewed Mar 1, 2024
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
giadas
giadas reviewed Mar 1, 2024
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
giadas
giadas reviewed Mar 1, 2024
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
giadas
giadas reviewed Mar 1, 2024
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
giadas
giadas reviewed Mar 1, 2024
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
@peppelinux peppelinux requested a review from giadas March 1, 2024 18:12
@peppelinux
Copy link
Member Author

@fmarino-ipzs @giadas I have decided to merge #226 in this PR
therefore, please, do your revisions on PR 226

then I'll fix the CI issues before merging in the branch versione-corrente

@peppelinux peppelinux mentioned this pull request Mar 2, 2024
Closed
Giuseppe De Marco and others added 2 commits March 4, 2024 17:29
@giadas @fmarino-ipzs
Errors that might occur during the presentation (#226)
eb75a03 
* RP errors

* Apply suggestions from code review

Co-authored-by: Giada Sciarretta <giada.sciarretta@gmail.com>

* fix: figure visualization issue

* fix: editorial

---------

Co-authored-by: Giada Sciarretta <giada.sciarretta@gmail.com>
Co-authored-by: fmarino-ipzs <fa.marino@ipzs.it>
@fmarino-ipzs
fix: renamed Wallet Trust Evidence in Wallet Attestation
7b2ea97
grausof
grausof approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@grausof grausof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Just a few small comments

docs/en/remote-flow.rst Outdated Show resolved Hide resolved
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
docs/en/remote-flow.rst Show resolved Hide resolved
@fmarino-ipzs fmarino-ipzs added this to the 0.6.0 milestone Mar 5, 2024
@peppelinux peppelinux mentioned this pull request Mar 5, 2024
Closed
peppelinux
peppelinux commented Mar 5, 2024
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
@grausof
Apply suggestions from code review
a685830 
Co-authored-by: Francesco Grauso <grausof@gmail.com>
@peppelinux
Copy link
Member Author

@grausof comments taken, thx

@peppelinux peppelinux merged commit 1cdf40b into versione-corrente Mar 5, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmarino-ipzs fmarino-ipzs fmarino-ipzs approved these changes

@giadas giadas giadas approved these changes

@grausof grausof grausof approved these changes

@balanza balanza Awaiting requested review from balanza

@asharif1990 asharif1990 Awaiting requested review from asharif1990

Assignees
No one assigned
Labels
None yet
Projects
EUDI Wallet IT Technical Specifications
Status: Done
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

Wallet Attestation in the presentation response
4 participants
@peppelinux @grausof @giadas @fmarino-ipzs