Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iat disclosable #201

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Iat disclosable #201

merged 3 commits into from
Feb 5, 2024

Conversation

fmarino-ipzs
Copy link
Collaborator

Title

iat claim is disclosable

Content

  • Closes [SD-JWT] iat is now disclosable #196
  • claims birthdate and place_of_birth are renamed in birth_date and birth_place in harmonization with mdoc-cbor data model
  • All non-normative example are re-generated accordingly
  • fixed some editorials (e.g. type --> vct in the non-normative example, etc.)

Review

  • Ensure your files are written following RST specs (not MD!)
  • Italian version
  • English version
  • Example files
  • Ask for review

@fmarino-ipzs fmarino-ipzs added this to the 0.6.0 milestone Feb 2, 2024
grausof
grausof approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@grausof grausof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

peppelinux
peppelinux approved these changes Feb 3, 2024
View reviewed changes
Copy link
Member

@peppelinux peppelinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I just suggest to remove a normative MAY since it doesn't give any value in the sentence

@fmarino-ipzs
Update docs/en/pid-eaa-data-model.rst
55c4847 
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
@peppelinux peppelinux merged commit 44d5d87 into versione-corrente Feb 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppelinux peppelinux peppelinux approved these changes

@grausof grausof grausof approved these changes

@balanza balanza Awaiting requested review from balanza

Assignees
No one assigned
Labels
None yet
Projects
EUDI Wallet IT Technical Specifications
Status: Done
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

[SD-JWT] iat is now disclosable
3 participants
@fmarino-ipzs @grausof @peppelinux