-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mdoc datamodel #166
Mdoc datamodel #166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
docs/en/pid-eaa-data-model.rst
Outdated
- *tstr (text string)*. Document type returned. For example for the PID, the value MUST be ``eu.europa.ec.eudiw.pid.1.`` For an mDL, the value MUST be ``org.iso.18013-5.1.mDL``. | ||
- [ISO 18013-5#8.3.2.1.2] | ||
* - **issuerSigned** | ||
- *bstr (byte string)*. Returned data elements signed by the Issuer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peppelinux , check if it sounds good to you now.
docs/en/pid-eaa-data-model.rst
Outdated
- *tstr (text string)*. Returned data elements for the namespaces. It MAY be possible to have one or more namespaces. It MAY be used for self-attested claims. | ||
- [ISO 18013-5#8.3.2.1.2] | ||
* - **deviceAuth** | ||
- *bstr (byte string)*. Contains the device authentication for MDOC data authentication. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peppelinux , check please
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
|
||
The document's data elements utilize a consistent namespace for the mandatory Mobile Driving License attributes, while the national PID attributes use the domestic namespace `eu.europa.ec.eudiw.pid.it.1`, as outlined in this implementation profile. | ||
|
||
In compliance with ISO/IEC 18013-5, the MDOC data model in the domestic namespace `eu.europa.ec.eudiw.pid.it.1`, requires the following attributes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peppelinux, checking again the ISO it seems that a domestic namespace should be eu.europa.ec.eudiw.pid.1.IT instead of eu.europa.ec.eudiw.pid.it.1.
WDYT?
@fmarino-ipzs introducing mdoc cbor has impacts on the issuance, |
* editorial: pid-eaa-data-model some rewording and fix * Apply suggestions from code review
I think that the Issuance protocol should be credential format agnostic. Otherwise, we have to parse the credential_definition claim according to the format one. The format should refer to the credential and not to the JSON which conveys the credential_definition claim. |
@fmarino-ipzs it's not our choice, this comes from the standards OpenID4VC and HAIP |
MDOC-CBOR Data Model
Content
This PR closes #18
Review