feat: Wallet Instance Attestation #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grausof
changed the title
grausof
requested review from
peppelinux
and removed request for
manuelcoppotelli
peppelinux
requested changes
Jun 17, 2023
…com/italia/eidas-it-wallet-docs into wallet-instance-attestation-SIW-151
peppelinux
requested changes
Jun 27, 2023
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
peppelinux
approved these changes
Jun 27, 2023
peppelinux
approved these changes
Jun 27, 2023
balanza
reviewed
Jun 28, 2023
peppelinux
requested changes
Jun 28, 2023
fmarino-ipzs
requested changes
Jun 28, 2023
|
|
||
| - **Message 1**: The User initializes the Wallet Instance. | ||
| In particular, this process happens when the mobile application | ||
| is launched and every time the User wants to request or present |
There was a problem hiding this comment.
When it is launched the first time after the installation and when it is expired. During the request or the presentation is under discussion. We have to take into account also the flows in presence and when the wallet instance does not have the connection.
There was a problem hiding this comment.
So how can we rephrase this sentence for now?
There was a problem hiding this comment.
@fmarino-ipzs please provide a suggestion to be committed
| || || client-assertion-type: | | ||
| || || ``jwt-key-attestation``. | | ||
| +------------------------------------+------------------------------------+ | ||
| || token_endpoint_auth_methods_suppo || Supported authentication method | |
There was a problem hiding this comment.
we must define what exactly is the supported client authentication method
| || rted || for the endpoint token. | | ||
| || || | | ||
| +------------------------------------+------------------------------------+ | ||
| || token_endpoint_auth_signing_alg_v || List of supported signature | |
There was a problem hiding this comment.
Depending on the supported client authentication mechanism we must have this parameter.
peppelinux
requested changes
Jun 28, 2023
| - **Message 4**: The Wallet Instance verifies that the Wallet Provider is | ||
| trustworthy by resolving the provider's trust chain up to the anchor | ||
| - **Message 5-7**: The Wallet Instance instantiates a new key pair on its TEE | ||
| and requests a ``nonce`` from the Wallet Provider (as a measure |
fmarino-ipzs
requested changes
Jul 3, 2023
| - **Message 4**: The Wallet Instance verifies that the Wallet Provider is | ||
| trustworthy by resolving the provider's trust chain up to the anchor | ||
| - **Message 5-7**: The Wallet Instance instantiates a new key pair on its TEE | ||
| and requests a ``nonce`` from the Wallet Provider (as a measure |
There was a problem hiding this comment.
The nonce parameter could be useful for Integrity API flow.
Co-authored-by: fmarino-ipzs <77629526+fmarino-ipzs@users.noreply.github.com>
peppelinux
approved these changes
Jul 3, 2023
fmarino-ipzs
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wallet Instance Attestation
This PR adds the design review of the
Wallet Instance Attestationincluding the request flow and format of theWallet Instance Attestation RequestandWallet Provider Entity Configurationresolve #4