Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment config #37

Merged
merged 20 commits into from
Feb 7, 2019
Merged

Deployment config #37

merged 20 commits into from
Feb 7, 2019

Conversation

libremente
Copy link
Member

Add deployment info for prod.
@alranel please check

@libremente libremente requested a review from alranel January 31, 2019 14:12
@libremente
Copy link
Member Author

libremente commented Jan 31, 2019

This PR also solves #35, #31 , #29 , #32 , #34

@libremente libremente self-assigned this Jan 31, 2019
gunzip -c onboarding.tar.gz | docker load /apps/www/onboarding.developers.italia.it/onboarding.tar.gz
docker stop onboarding
docker rm onboarding
docker run --name=onboarding --restart=always -p 8003:80 -e env=pm-prod -v $(pwd)/apps/www/onboarding.developers.italia.it/smtp-account-config.json:/usr/src/app/smtp-account-config.json onboarding
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
docker run --name=onboarding --restart=always -p 8003:80 -e env=pm-prod -v $(pwd)/apps/www/onboarding.developers.italia.it/smtp-account-config.json:/usr/src/app/smtp-account-config.json onboarding
docker run --name=onboarding --restart=always -p 8003:80 -e env=pm-prod -v /apps/www/onboarding.developers.italia.it/smtp-account-config.json:/usr/src/app/smtp-account-config.json onboarding

@libremente
Copy link
Member Author

libremente commented Feb 7, 2019

New decisions:

  • Deployment passes through dockerHub
  • CI passes through circleci (now installs and lints, in the future tests)

@libremente libremente merged commit 23ee56e into master Feb 7, 2019
@libremente libremente deleted the deployment-config branch February 7, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants