Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: query /v1/publishers/${ipa} #236

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix: query /v1/publishers/${ipa} #236

merged 1 commit into from
Oct 21, 2024

Conversation

tensor5
Copy link
Contributor

@tensor5 tensor5 commented Oct 17, 2024

Querying /v1/publishers/${ipa}-${pec} yields 404.

@tensor5 tensor5 requested a review from bfabio October 17, 2024 15:57
@tensor5 tensor5 force-pushed the fix-get-publishers branch 3 times, most recently from 253db90 to 0d4ae09 Compare October 17, 2024 16:12
Copy link
Member

@bfabio bfabio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it should've been in af4b797.

It needs to be in

const getPublisherResp = await fetch(`${apiURL}/publishers/${ipa}-${pec}`, {
as well though

@tensor5 tensor5 requested a review from bfabio October 21, 2024 07:26
Querying `/v1/publishers/${ipa}-${pec}` yields 404.
@tensor5 tensor5 force-pushed the fix-get-publishers branch from fe428c4 to 39322a5 Compare October 21, 2024 14:03
@tensor5 tensor5 merged commit 39322a5 into master Oct 21, 2024
3 checks passed
@tensor5 tensor5 deleted the fix-get-publishers branch October 21, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants