Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use fiber constant for error message #168

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Conversation

bfabio
Copy link
Member

@bfabio bfabio commented Oct 10, 2022

No description provided.

@bfabio bfabio requested a review from LorenzoS92 October 10, 2022 17:27
@LorenzoS92
Copy link
Contributor

Some linter errors

@bfabio
Copy link
Member Author

bfabio commented Oct 11, 2022

Leaving this open for now as a reminder as it's just a small enhancement which doesn't warrant too much effort and the linter errors would be properly resolved if we used generics anyway.

Copy link

gitguardian bot commented Mar 7, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9772134 Triggered Generic Password bc3fa9e .github/workflows/tests-postgresql.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@bfabio
Copy link
Member Author

bfabio commented Mar 7, 2024

@GitGuardian relax, it's a test config

@bfabio bfabio merged commit 758a3ae into main Mar 7, 2024
9 checks passed
@bfabio bfabio deleted the error-strings branch March 7, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants