Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to hoisted CSF annotations #750

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

edoardolincetto
Copy link
Contributor

Fixes #745

PR Checklist

  • My branch is up-to-date with the Upstream master branch.
  • The unit tests pass locally with my changes (if applicable).
  • I have added tests that prove my fix is effective or that my feature works (if applicable).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves:

Storybook 6 introduces hoisted CSF annotations and deprecates the StoryFn.story object-style annotation.

@vercel
Copy link

vercel bot commented Oct 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/dip-trasformazione-digitale/design-react-kit/5SugA943oHAiXes6cKUZpMdkQsWP
✅ Preview: https://design-react-kit-git-fork-ed-8678ad-dip-trasformazione-digitale.vercel.app

@dej611
Copy link
Member

dej611 commented Oct 13, 2021

🎉 Thanks for your contribution!
Looks great, it seems there are few pages still with the warning:

Can you fix also these?

Copy link
Member

@sanyamdogra sanyamdogra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge after the requested changes 👍
Over to @dej611

@edoardolincetto
Copy link
Contributor Author

Hi @dej611, that's a different issue... 😕
Nothing to fix to remove these warnings. storyFn is never used in the project.

Quoting the Storybook repo:

NOTE: If you're using @storybook/addon-docs, this deprecation warning is triggered by the Docs tab in 6.1. It's safe to ignore and we will be providing a proper fix in a future release. You can track the issue at storybookjs/storybook#13074.

It will be fixed in future releases, so @sanyamdogra I think we can open another specific issue.

@dej611 dej611 merged commit 67cc223 into italia:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ops] Move to new CSF storyName format
3 participants