Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: group form in examples #1112

Merged
merged 5 commits into from
Oct 31, 2024
Merged

fix: group form in examples #1112

merged 5 commits into from
Oct 31, 2024

Conversation

astagi
Copy link
Member

@astagi astagi commented Oct 15, 2024

Fixes #

PR Checklist

  • My branch is up-to-date with the Upstream main branch.
  • The unit tests pass locally with my changes (if applicable).
  • I have added tests that prove my fix is effective or that my feature works (if applicable).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves:

Changes proposed in this Pull Request:

Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
design-react-kit ✅ Ready (Inspect) Visit Preview Oct 31, 2024 5:17pm

Copy link

@Fupete Fupete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ciao @astagi. Ho solo notato che c'è una stranezza. Alcune varianti hanno una classe .m-3 applicata al tag form che applica un margine interno.
Ora che c'è la legend sopra si vede bene la differenza. Es. Checkbox, guarda la distanza tra legende e checkboxes, e l'allineamento a sinistra di queste:

immagine

@Fupete Fupete linked an issue Oct 19, 2024 that may be closed by this pull request
1 task
@astagi
Copy link
Member Author

astagi commented Oct 22, 2024

@Fupete dici è il caso di togliere quel margine .m-3?

@Fupete
Copy link

Fupete commented Oct 22, 2024

@Fupete dici è il caso di togliere quel margine .m-3?

O lo leviamo o si mette a tutte le varianti, anche in BSI... c'è da studiarci. Io proporrei di toglierlo poi si vede successivamente se riaggiungere via css dello spazio dovunque in caso sotto la legend.

@astagi astagi merged commit b8e5223 into main Oct 31, 2024
5 checks passed
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.34%. Comparing base (7794d30) to head (c38856f).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1112      +/-   ##
==========================================
- Coverage   97.34%   97.34%   -0.01%     
==========================================
  Files         357      357              
  Lines       25309    25305       -4     
  Branches     1687     1688       +1     
==========================================
- Hits        24637    24633       -4     
  Misses        670      670              
  Partials        2        2              
Flag Coverage Δ
unittests 97.34% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Componente Radio Button: cosa si intende per gruppo?
2 participants