Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert possible Kotlin object classes to data classes #323

Closed
itachi1706 opened this issue Jun 21, 2019 · 0 comments
Closed

Convert possible Kotlin object classes to data classes #323

itachi1706 opened this issue Jun 21, 2019 · 0 comments
Assignees
@itachi1706
Labels
enhancement:games enhancement:general enhancement:utility in-progress

Comments

@itachi1706
Copy link
Owner

itachi1706 commented Jun 21, 2019 •
edited
Loading

Anything that does not have custom constructors, getters or setters can fall into this category

https://kotlinlang.org/docs/reference/data-classes.html
@itachi1706 itachi1706 self-assigned this Jun 21, 2019
itachi1706 added a commit that referenced this issue Jun 21, 2019
@itachi1706
Converted the remaining objects to Kotlin data classes (#323)
4461753 
Instead of leaving it as normal classes (and requiring our own implementation for equals and hashcode), we convert them to data classes and utilize seperate constructor classes to aid in further constructor processing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itachi1706 itachi1706

Labels
enhancement:games enhancement:general enhancement:utility in-progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@itachi1706