chore(deps): update dependency squizlabs/php_codesniffer to v3.11.3 #822
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
|
Warning Rate limit exceeded@renovate[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 26 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (11)
📒 Files selected for processing (5)
WalkthroughThe composer configurations for multiple projects have been updated. The "prepare-dirs" script has been removed from both the Changes
Possibly related PRs
Suggested reviewers
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
zmsapi/composer.json (1)
50-57: Enhanced 'wget-files' script commands.
The updated commands now include downloading the Swagger JSON file directly to public/doc/swagger.json, which aligns nicely with the new documentation strategy. The remaining asset download commands seem to still be in place; please verify that all these files are still needed in zmsapi. For improved robustness, you might consider appending error-checking flags (or handling failures using Composer’s scripting capabilities) to these shell commands.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (12)
mellon/composer.lockis excluded by!**/*.lockzmsadmin/composer.lockis excluded by!**/*.lockzmsapi/composer.lockis excluded by!**/*.lockzmscalldisplay/composer.lockis excluded by!**/*.lockzmscitizenapi/composer.lockis excluded by!**/*.lockzmsclient/composer.lockis excluded by!**/*.lockzmsdldb/composer.lockis excluded by!**/*.lockzmsentities/composer.lockis excluded by!**/*.lockzmsmessaging/composer.lockis excluded by!**/*.lockzmsslim/composer.lockis excluded by!**/*.lockzmsstatistic/composer.lockis excluded by!**/*.lockzmsticketprinter/composer.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
zmsapi/composer.json(1 hunks)zmscitizenapi/composer.json(0 hunks)
💤 Files with no reviewable changes (1)
- zmscitizenapi/composer.json
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
zmsapi/composer.json (1)
58-63: Streamlined post-installation and post-update commands.
Post-install and post-update hooks now exclusively invoke the @wget-files command, reflecting the removal of the old prepare-dirs script. This simplification is in line with the broader project changes across repositories.
renovate
bot
force-pushed
the
renovate/squizlabs-php_codesniffer-3.x-lockfile
branch
from
6ae6a5d to
7eb448a
Compare
|
renovate
bot
force-pushed
the
renovate/squizlabs-php_codesniffer-3.x-lockfile
branch
from
7eb448a to
4b19b1a
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
zmsdb/composer.json (1)
76-76: Review Divergent PHPCS Version ConstraintThe
"squizlabs/php_codesniffer"dependency now uses the version constraint"^2.4", which is notably different from the constraint used in the zmsclient package ("^3.5.8"). This divergence may be intentional due to compatibility requirements, but it can lead to inconsistent behavior in code quality checks across different parts of the project. Please confirm that this decision is deliberate, and if not, consider aligning the version constraints.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (11)
mellon/composer.lockis excluded by!**/*.lockzmsadmin/composer.lockis excluded by!**/*.lockzmsapi/composer.lockis excluded by!**/*.lockzmscalldisplay/composer.lockis excluded by!**/*.lockzmscitizenapi/composer.lockis excluded by!**/*.lockzmsclient/composer.lockis excluded by!**/*.lockzmsdldb/composer.lockis excluded by!**/*.lockzmsentities/composer.lockis excluded by!**/*.lockzmsmessaging/composer.lockis excluded by!**/*.lockzmsslim/composer.lockis excluded by!**/*.lockzmsticketprinter/composer.lockis excluded by!**/*.lock
📒 Files selected for processing (4)
zmsapi/composer.json(1 hunks)zmscitizenapi/composer.json(0 hunks)zmsclient/composer.json(1 hunks)zmsdb/composer.json(1 hunks)
💤 Files with no reviewable changes (1)
- zmscitizenapi/composer.json
🚧 Files skipped from review as they are similar to previous changes (1)
- zmsapi/composer.json
⏰ Context from checks skipped due to timeout of 90000ms (13)
- GitHub Check: call-owasp-security-checks / security-scan (zmsclient, 8.0)
- GitHub Check: call-owasp-security-checks / security-scan (zmsslim, 8.0)
- GitHub Check: call-owasp-security-checks / security-scan (zmsentities, 8.0)
- GitHub Check: call-owasp-security-checks / security-scan (zmsdldb, 8.0)
- GitHub Check: call-php-code-quality / module-code-quality (zmsclient, 8.0)
- GitHub Check: call-owasp-security-checks / security-scan (zmsticketprinter, 8.0)
- GitHub Check: call-php-code-quality / module-code-quality (zmscitizenapi, 8.0)
- GitHub Check: call-owasp-security-checks / security-scan (zmsstatistic, 8.0)
- GitHub Check: call-owasp-security-checks / security-scan (zmsmessaging, 8.0)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: call-php-unit-tests / zmsapi-test
- GitHub Check: call-owasp-security-checks / security-scan (zmsapi, 8.0)
- GitHub Check: call-owasp-security-checks / security-scan (zmsadmin, 8.0)
🔇 Additional comments (2)
zmsclient/composer.json (1)
57-57: Constrain PHPCS Version in Dev DependenciesThe update changes the
"squizlabs/php_codesniffer"dependency from a loose constraint ("*"), to a semantically restricted range ("^3.5.8"). This ensures that only versions from 3.5.8 up to, but not including, 4.0.0 are allowed. Verify that this range is aligned with your project’s coding standards and that it indeed permits upgrade to v3.11.3 as noted by the PR objectives.zmsdb/composer.json (1)
75-75: Specify PHPMD Version for Predictable Quality ChecksThe dependency for
"phpmd/phpmd"has been updated from"@stable"to"^2.3". This explicit version constraint helps ensure consistent behavior across environments. Confirm that version^2.3is tested with your codebase.
renovate
bot
force-pushed
the
renovate/squizlabs-php_codesniffer-3.x-lockfile
branch
from
4b19b1a to
423507d
Compare
This PR contains the following updates:
3.11.2->3.11.33.9.2->3.11.3Release Notes
PHPCSStandards/PHP_CodeSniffer (squizlabs/php_codesniffer)
v3.11.3Compare Source
Changed
SpaceBeforeCommaerror. #783Fixed
equalsSpacingwas set to0.equalsSpacingwas set to1.Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.
Summary by CodeRabbit