Update antlr4 dep for cel, to fix crash #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also change https://github.com/istio/proxy/blob/release-1.7/WORKSPACE#L80 to 472? |
|
/test test-tsan_envoy_release-1.7 |
1 similar comment
|
/test test-tsan_envoy_release-1.7 |
|
@mandarjog per @kyessenov you need to update the |
This was referenced Aug 14, 2020
Merged
PiotrSikora
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates antlr to fix envoyproxy/envoy-wasm#497
At that time only cel-cpp was updated, but not antlr.
We do not have a unit test that produces the crash.
I have verified that crash does happen with 1.7 build and it does not happen with build that includes antlr-4.7.2.