Skip to content

Commit

Permalink
bazel: replace tclap mirror. (envoyproxy#9072)
Browse files Browse the repository at this point in the history
Description:

Change (non-existent) https://github.com/eile/tclap/ to https://github.com/mirror/tclap/. I didn't validate the new mirror in any way, but the downloded release file sha256sum stays the same. In the future the releases should probably be downloaded from the real upstream. However the release 1.2.1 tarball from https://sourceforge.net/projects/tclap/files/ did not have the same sha256sum as the release file which Envoy uses.

Risk Level: Medium
Testing: N/A
Docs Changes: N/A
Release Notes:
Fixes envoyproxy#9071

Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com>
  • Loading branch information
ipuustin authored and yxue committed Nov 20, 2019
1 parent b6410d6 commit 7c267c3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions bazel/repositories.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def envoy_dependencies(skip_targets = []):
_com_github_circonus_labs_libcircllhist()
_com_github_c_ares_c_ares()
_com_github_cyan4973_xxhash()
_com_github_eile_tclap()
_com_github_mirror_tclap()
_com_github_fmtlib_fmt()
_com_github_gabime_spdlog()
_com_github_gcovr_gcovr()
Expand Down Expand Up @@ -229,14 +229,14 @@ def _com_github_envoyproxy_sqlparser():
actual = "@com_github_envoyproxy_sqlparser//:sqlparser",
)

def _com_github_eile_tclap():
def _com_github_mirror_tclap():
_repository_impl(
name = "com_github_eile_tclap",
name = "com_github_mirror_tclap",
build_file = "@envoy//bazel/external:tclap.BUILD",
)
native.bind(
name = "tclap",
actual = "@com_github_eile_tclap//:tclap",
actual = "@com_github_mirror_tclap//:tclap",
)

def _com_github_fmtlib_fmt():
Expand Down
4 changes: 2 additions & 2 deletions bazel/repository_locations.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@ REPOSITORY_LOCATIONS = dict(
strip_prefix = "sql-parser-5f50c68bdf5f107692bb027d1c568f67597f4d7f",
urls = ["https://github.com/envoyproxy/sql-parser/archive/5f50c68bdf5f107692bb027d1c568f67597f4d7f.tar.gz"],
),
com_github_eile_tclap = dict(
com_github_mirror_tclap = dict(
sha256 = "f0ede0721dddbb5eba3a47385a6e8681b14f155e1129dd39d1a959411935098f",
strip_prefix = "tclap-tclap-1-2-1-release-final",
urls = ["https://github.com/eile/tclap/archive/tclap-1-2-1-release-final.tar.gz"],
urls = ["https://github.com/mirror/tclap/archive/tclap-1-2-1-release-final.tar.gz"],
),
com_github_fmtlib_fmt = dict(
sha256 = "4c0741e10183f75d7d6f730b8708a99b329b2f942dad5a9da3385ab92bb4a15c",
Expand Down

0 comments on commit 7c267c3

Please sign in to comment.