Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put the state and nonce into the session store instead of using a cookie #69

Closed
cfryanr opened this issue Feb 21, 2020 · 0 comments · Fixed by #71
Closed

Put the state and nonce into the session store instead of using a cookie #69

cfryanr opened this issue Feb 21, 2020 · 0 comments · Fixed by #71

Comments

@cfryanr
Copy link

cfryanr commented Feb 21, 2020

This will simplify the code and will remove the need for the cryptor_secret configuration option.

It will also make the authservice compatible with any version of Istio/envoy, even versions from before the Set-Cookie bug that we fixed (that fix was first included in Istio 1.5).
cfryanr added a commit that referenced this issue Feb 25, 2020
@cfryanr @Changdrew
Move the state and nonce from an encrypted cookie into the session store
faef663 
- Removes two configuration options that are no longer needed:
  `cryptor_secret` and `timeout`
- Removes the cookie encryption code and related helpers
- Does not set or delete the state cookie anymore
- Adds the state and nonce values to the session store
- Renamed the SessionIdGenerator to SessionStringGenerator because it
  now also generates state and nonce values

[Issue #69]

Signed-off-by: Andrew Chang <anchang@pivotal.io>
@cfryanr cfryanr mentioned this issue Feb 26, 2020
Merged
cfryanr pushed a commit that referenced this issue Feb 26, 2020
@Changdrew @cfryanr
Fix a memory management mistake in oidc_filter_test.cc
70f531b 
- Remove an unused include in in_memory_session_store_test.cc
- Add a new target in the Makefile to help run focused tests from
  the command line

[Issue #69]

Signed-off-by: Ryan Richard <rrichard@pivotal.io>
nacx added a commit to nacx/authservice that referenced this issue Mar 11, 2024
@nacx
Publish docker images to ghcr (istio-ecosystem#69)
130d581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move the state and nonce from an encrypted cookie into the session store istio-ecosystem/authservice
1 participant
@cfryanr