Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MESH-0000: remove metrics due to sample limit #370

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

rtay1188
Copy link
Collaborator

@rtay1188 rtay1188 commented Jan 2, 2025

Checklist

🚨 Please review this repository's contribution guidelines.

  • I've read and agree to the project's contribution guidelines.
  • I'm requesting to pull a topic/feature/bugfix branch.
  • I checked that my code additions will pass code linting checks and unit tests.
  • I updated unit and integration tests (if applicable).
  • I'm ready to notify the team of this contribution.

Description

These are metrics used to test new monitoring capabilities for Admiral 2.0. They should be removed from the current Admiral as they are overloading the sample limit.

Signed-off-by: Ryan Tay <ryan_tay@intuit.com>
@rtay1188 rtay1188 force-pushed the MESH-0000-remove-test-metrics branch from 5964a96 to 4406a6e Compare January 2, 2025 18:53
Signed-off-by: Ryan Tay <ryan_tay@intuit.com>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 63.19%. Comparing base (ed49448) to head (255a04a).

Files with missing lines Patch % Lines
admiral/pkg/clusters/serviceentry.go 0.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #370      +/-   ##
==========================================
- Coverage   63.25%   63.19%   -0.06%     
==========================================
  Files          91       91              
  Lines       12158    12159       +1     
==========================================
- Hits         7690     7684       -6     
- Misses       4053     4059       +6     
- Partials      415      416       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rtay1188 rtay1188 merged commit 2d8cf04 into master Jan 2, 2025
3 checks passed
@rtay1188 rtay1188 deleted the MESH-0000-remove-test-metrics branch January 2, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants