MESH-5878: Admiral does not create envoy filter on client onboardings

- Only modify cache when not an error Signed-off-by: Adil Fulara <adil_fulara@intuit.com>
istio-ecosystem · Jan 3, 2025 · 7a7e9d9 · 7a7e9d9
1 parent a95dd31
commit 7a7e9d9
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/admiral/pkg/clusters/routingpolicy_handler.go b/admiral/pkg/clusters/routingpolicy_handler.go
@@ -51,15 +51,15 @@ func (r *RoutingPolicyService) ProcessAddOrUpdate(ctx context.Context, eventType
 					err = common.AppendError(err, err1)
 				} else {
 					log.Infof(LogFormat, eventType, "routingpolicy	", newRP.Name, remoteController.ClusterID, "created envoyfilters")
+					id := common.GetRoutingPolicyIdentity(newRP)
+					if oldRP != nil {
+						oldEnv := common.GetRoutingPolicyEnv(oldRP)
+						r.RemoteRegistry.AdmiralCache.RoutingPolicyCache.Delete(id, oldEnv, oldRP.Name)
+					}
+					env := common.GetRoutingPolicyEnv(newRP)
+					r.RemoteRegistry.AdmiralCache.RoutingPolicyCache.Put(id, env, newRP.Name, newRP)
 				}
 			}
-			id := common.GetRoutingPolicyIdentity(newRP)
-			if oldRP != nil {
-				oldEnv := common.GetRoutingPolicyEnv(oldRP)
-				r.RemoteRegistry.AdmiralCache.RoutingPolicyCache.Delete(id, oldEnv, oldRP.Name)
-			}
-			env := common.GetRoutingPolicyEnv(newRP)
-			r.RemoteRegistry.AdmiralCache.RoutingPolicyCache.Put(id, env, newRP.Name, newRP)
 		}
 	}
 	return err