fix: ignore lines have to be dropped from coverage and not to be incl…

…uded as covered
istanbuljs · Feb 6, 2024 · 521dee7 · 521dee7
1 parent 4488d10
commit 521dee7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 24 deletions.
diff --git a/lib/v8-to-istanbul.js b/lib/v8-to-istanbul.js
@@ -281,8 +281,11 @@ module.exports = class V8ToIstanbul {
       s: {}
     }
     source.lines.forEach((line, index) => {
+      if (line.ignore) {
+        return;
+      }
       statements.statementMap[`${index}`] = line.toIstanbul()
-      statements.s[`${index}`] = line.ignore ? 1 : line.count
+      statements.s[`${index}`] = line.count
     })
     return statements
   }

diff --git a/tap-snapshots/test/v8-to-istanbul.js.test.cjs b/tap-snapshots/test/v8-to-istanbul.js.test.cjs
@@ -385,8 +385,6 @@ Object {
     "31": 1,
     "32": 1,
     "33": 1,
-    "34": 1,
-    "35": 1,
     "36": 1,
     "37": 1,
     "4": 1,
@@ -677,26 +675,6 @@ Object {
         "line": 34,
       },
     },
-    "34": Object {
-      "end": Object {
-        "column": 22,
-        "line": 35,
-      },
-      "start": Object {
-        "column": 0,
-        "line": 35,
-      },
-    },
-    "35": Object {
-      "end": Object {
-        "column": 28,
-        "line": 36,
-      },
-      "start": Object {
-        "column": 0,
-        "line": 36,
-      },
-    },
     "36": Object {
       "end": Object {
         "column": 1,

diff --git a/test/v8-to-istanbul.js b/test/v8-to-istanbul.js
@@ -163,7 +163,7 @@ ${'//'}${'#'} sourceMappingURL=data:application/json;base64,${base64Sourcemap}
       const coverageMap = v8ToIstanbul.toIstanbul()
       const { s } = coverageMap[filename]
 
-      assert.deepStrictEqual(s, { 0: 1, 1: 1, 2: 1, 3: 1 })
+      assert.deepStrictEqual(s, {})
     })
   })