Drop support for python 2.6 and 3.3 #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
force-pushed
the
drop-support-for-python-2.6-and-3.3
branch
from
652fb8d
to
8328755
Compare
Drop support for Python 2.6 and 3.3
cclauss
force-pushed
the
drop-support-for-python-2.6-and-3.3
branch
from
8328755
to
b569b19
Compare
|
It's ok for me. I'll merge this in the coming days. |
jelmer
reviewed
Jan 31, 2018
.travis.yml
Outdated
| - sudo rm -rf /dev/shm && sudo ln -s /run/shm /dev/shm | ||
| script: | ||
| - tox -e $TOX_ENV | ||
| - python -m pyflakes.__main__ $(git ls-files | grep -E "^isso/.+.py$" | grep -v "^isso/compat.py") | ||
| # stop the build if there are Python syntax errors or undefined names |
There was a problem hiding this comment.
Please keep the move to flake8 as a separate change. This is different from just dropping Python2.6/3.3 support, and changes what kind of syntax errors will be fatal.
|
Looks good to me, with the exception of the flake changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #379
Also steps up from pyflakes to flake8 for testing.
pypa/pip#3955