Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep product auto_item unused in AbstractProduct::getCssClass() #2554

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

fritzmg
Copy link
Contributor

@fritzmg fritzmg commented Dec 9, 2024

The ProductList retrieves each individual product's CSS class here:

'class' => $objProduct->getCssClass(),

This causes invalid auto_item URLs on the product list page to become valid (i.e. they will not show 404). For example if you have a product list on

https://example.com/shop

then the invalid URL

https://example.com/shop/not-a-valid-url-parameter

will not show the 404 page. Instead it will just show the contents of the https://example.com/shop page.

This PR fixes that by enabling the $blnKeepUnused parameter.

@aschempp aschempp merged commit 8d84e12 into isotope:2.9 Dec 18, 2024
@aschempp
Copy link
Member

Thank you @fritzmg

@fritzmg fritzmg deleted the patch-19 branch December 18, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants