Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming RelationTracker to DatabaseInfo + updated method. #372

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

isoos
Copy link
Owner

@isoos isoos commented Sep 10, 2024

No description provided.

@isoos
Copy link
Owner Author

isoos commented Sep 10, 2024

/cc @wolframm: I believe it is fine to revert the mostly-unused public sync parsing methods to no use any type decoding (as it was in a previous stable), but use the async version while actively decoding the message.

/cc @ankane: I think DatabaseInfo may work as a better name and concept for querying the type information - even on demand, I am a bit undecided on which direction it will take. However I think it would be feasible if these instance would get either a dedicated connection pool from the user setting them up, or automatically create a pool with max-instance of 1 and use it if/when the query is needed.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 59.25926% with 11 lines in your changes missing coverage. Please review.

Project coverage is 84.72%. Comparing base (12e1cbf) to head (acd8609).
Report is 30 commits behind head on master.

Files with missing lines Patch % Lines
lib/src/v3/database_info.dart 20.00% 8 Missing ⚠️
lib/src/messages/logical_replication_messages.dart 62.50% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #372      +/-   ##
==========================================
- Coverage   86.60%   84.72%   -1.88%     
==========================================
  Files          28       31       +3     
  Lines        2964     3182     +218     
==========================================
+ Hits         2567     2696     +129     
- Misses        397      486      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isoos isoos force-pushed the dbinfo branch 2 times, most recently from 22d0e22 to 7509a49 Compare September 12, 2024 20:44
@isoos isoos merged commit 76601a1 into master Sep 12, 2024
@isoos isoos deleted the dbinfo branch September 12, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants