Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass TypeRegistry into Sql tokenization. #268

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Pass TypeRegistry into Sql tokenization. #268

merged 1 commit into from
Dec 5, 2023

Conversation

isoos
Copy link
Owner

@isoos isoos commented Dec 4, 2023

No description provided.

@isoos
Copy link
Owner Author

isoos commented Dec 4, 2023

/cc @simolus3. I remember you were suggesting something similar a few weeks ago, but I couldn't find the comment. I think this is along those lines, and it passes the TypeRegistry to the parser without too much pain. wdyt?

simolus3
simolus3 reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@simolus3 simolus3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty much exactly what I had in mind, yes 👍

@isoos
Copy link
Owner Author

isoos commented Dec 5, 2023

Thanks for the verification!

@isoos isoos merged commit 3e65bc8 into master Dec 5, 2023
1 check passed
@isoos isoos deleted the sql-impl branch December 5, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simolus3 simolus3 simolus3 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isoos @simolus3