Feat/is 399 ggs create file #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderleegs
force-pushed
the
feat/is-399-ggs-create-file
branch
from
95a7509 to
3b0a52b
Compare
dcshzj
reviewed
Aug 14, 2023
dcshzj
reviewed
Aug 14, 2023
dcshzj
approved these changes
Aug 14, 2023
harishv7
reviewed
Aug 14, 2023
| ) | ||
|
|
||
| expect(result._unsafeUnwrapErr()).toBeInstanceOf(NotFoundError) | ||
| expect(result.isErr()).toBeTrue() |
There was a problem hiding this comment.
how about tests to ensure rollbacks are done correctly - i.e. when failures occur along one of the many steps in create flow
There was a problem hiding this comment.
Hmm we actually only rollback in either the actual file creation, or when committing the change. I'm not entirely sure how to mock the fs call itself!
There was a problem hiding this comment.
okay, let's focus on the manual testing for rollback and add this in later. I think @dcshzj added a mock-fs library into the spec file which we can use possibly
2 tasks
alexanderleegs
force-pushed
the
feat/is-399-ggs-create-file
branch
from
f0dd458 to
c4a9ab6
Compare
harishv7
approved these changes
Aug 15, 2023
alexanderleegs
added a commit
that referenced
this pull request
Aug 15, 2023
* IS-401: Write extend repo service to support delete files folders (#894) * feat: base code for delete file * feat: add base delete directory steps * feat: refactor into one delete function * feat: split RepoService delete into two * fix: remove unused imports * feat: update return types * fix: BDS tests * feat: tests for delete in RepoService * fix: remove update tree function for ggs flow * feat: add tests for GFS * feat: add tests for delete * feat: add check for latest commit * fix: uncomment push * fix: add log * feat: add tests * Feat/is 399 ggs create file (#892) * refactor: safeExistsSync * chore: upgrade js-base64 * feat: add create methods * test: add tests * refactor: remove safeExistsSync and use getFilePathStats instead * test: add tests for rollback * feat: push on creation * chore: update missing import * chore: change to pass arguments directly * chore: replace return type with GitCommitResult * fix: remove unnecessary maps * fix: swap returned error on creating file * chore: remove unused import * fix: handle stats from retrieving directory info * nit: swap return from empty string to boolean * chore: improve log statement * fix: update assertion of error * feat: add optional force param to push * feat: add rollback functionality for whitelisted ggs sites * fix: rebase errors * fix: use false as default for isForce --------- Co-authored-by: Harish <harish@open.gov.sg>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR introduces creates to our GGS solution. Resolves IS-399. This PR also modifies checks for the existence of paths to use
gitFilePathStatsinstead offs.existsSync.Features:
cloneandisValidGitRepoto usegetFilePathStatsinsteadFuture work: