feat(GGs): implement update operation #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcshzj
changed the title
harishv7
reviewed
Aug 10, 2023
harishv7
reviewed
Aug 10, 2023
harishv7
reviewed
Aug 11, 2023
QiluXie
reviewed
Aug 11, 2023
| logger.warn(`Rolling repo ${repoName} back to ${commitSha}`) | ||
| return ResultAsync.fromPromise( | ||
| this.git | ||
| .cwd(`${EFS_VOL_PATH}/${repoName}`) |
There was a problem hiding this comment.
nit: better to use path.join instead of template literals?
There was a problem hiding this comment.
Hmm I think same comment with Harish, mainly to keep the code consistent. I think we never really used path.join before, might be a discussion we should have team-wide.
| filePath: string | ||
| ): ResultAsync<fs.Stats, NotFoundError | GitFileSystemError> { | ||
| return ResultAsync.fromPromise( | ||
| fs.promises.stat(`${EFS_VOL_PATH}/${repoName}/${filePath}`), |
There was a problem hiding this comment.
nit: better to use path.join instead of template literals?
| .andThen(() => | ||
| ResultAsync.fromPromise( | ||
| fs.promises.writeFile( | ||
| `${EFS_VOL_PATH}/${repoName}/${filePath}`, |
| ): Promise<GitCommitResult> { | ||
| if (this.isRepoWhitelisted(sessionData.siteName)) { | ||
| logger.info("Updating file in local Git file system") | ||
| const filePath = directoryName ? `${directoryName}/${fileName}` : fileName |
QiluXie
approved these changes
Aug 11, 2023
harishv7
reviewed
Aug 11, 2023
dcshzj
force-pushed
the
feat/ggs-update
branch
from
a85859a to
8e4a180
Compare
harishv7
approved these changes
Aug 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes IS-400.
Solution
Breaking Changes
Features:
Tests
Deploy Notes
None