Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: throw ConflictError if 409 received #84

Merged

Conversation

alexanderleegs
Copy link
Contributor

This PR allows ConflictError to be thrown if a 409 error is received from the Github API. To be reviewed with PR [#247]isomerpages/isomercms-frontend#247 on the isomercms-frontend repo.

Copy link
Contributor

@kwajiehao kwajiehao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexanderleegs alexanderleegs merged commit 34085ad into staging Dec 1, 2020
@alexanderleegs alexanderleegs deleted the feat/throw-409-error-if-received-from-github-api branch December 1, 2020 08:43
@kwajiehao kwajiehao mentioned this pull request Dec 9, 2020
harishv7 pushed a commit that referenced this pull request Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants