Fix: handle updating of files in root directory #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kishore03109
approved these changes
May 9, 2023
Merged
alexanderleegs
added a commit
that referenced
this pull request
May 9, 2023
* fix: close pull request (#751) * Fix: publish button delay (#752) * Fix: publish button delay * Fix: tests * Fix: move review request status check into router * feat: return sites from db for email login (#754) * feat: return sites from db for email login * fix: tests * fix: use lodash function for type guard * fix(githhub service): get call to github to prevent race condition (#756) * fix(githhub service): get call to github to prevent race condition * fix(github service): throw error if directory name not defined * style(github service): add comments for clarity * fix: tests --------- Co-authored-by: Alexander Lee <alexander@open.gov.sg> * Fix: handle updating of files in root directory (#761) * fix: create .keep first when rename subfolder (#762) * 0.26.0 --------- Co-authored-by: seaerchin <44049504+seaerchin@users.noreply.github.com> Co-authored-by: Alexander Lee <alexander@open.gov.sg> Co-authored-by: Harish <harish@open.gov.sg>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in our update behaviour - we were previously checking that the directory a file was in exists before making any update call, but this was failing for our root directory. This PR skips the check if the file belongs to our root directory. Note that
Createdoes not need to have this same behaviour - we never create files inside our root folder.