Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(authservice): return userId when e2e #700

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Conversation

seaerchin
Copy link
Contributor

Problem

FE uses !!userId to determine if a user should be directed to the github login flow (which is what our tests work with), this requires a backend change to also return userId when it is the E2E_USER. separately, we should probably maintain 2 types of users for e2e (github + email) or, if we decide that we want to deprecate github in the future, make our existing tests compat w/ email flow
Related to IS-87

Solution

add userId property when e2e

@seaerchin seaerchin requested a review from a team April 12, 2023 10:11
@harishv7
Copy link
Contributor

we should probably maintain 2 types of users for e2e (github + email) or, if we decide that we want to deprecate github in the future, make our existing tests compat w/ email flow

Have we created an epic/tickets for this?

@seaerchin
Copy link
Contributor Author

we should probably maintain 2 types of users for e2e (github + email) or, if we decide that we want to deprecate github in the future, make our existing tests compat w/ email flow

Have we created an epic/tickets for this?

not at the moment cos i wanted to see which flow y'all would be more comfortable with. i'm just gonna file the comment as an issue as-is HAHA but just putting it here that i think maintaining 2 types of E2E (at first) is more robust

@seaerchin
Copy link
Contributor Author

seaerchin commented Apr 13, 2023

filed as IS-99

@seaerchin seaerchin merged commit c266405 into develop Apr 13, 2023
@seaerchin seaerchin deleted the test/e2e-setup branch April 13, 2023 03:40
@kishore03109 kishore03109 mentioned this pull request Apr 13, 2023
@alexanderleegs alexanderleegs mentioned this pull request Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants