Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup GitHub actions #64

Merged
merged 6 commits into from
Nov 4, 2020
Merged

Setup GitHub actions #64

merged 6 commits into from
Nov 4, 2020

Conversation

kwajiehao
Copy link
Contributor

This PR sets up GitHub Actions for the CMS backend. In the process, we also remove our Travis configuration file since we don't want to double build and subsequently deploy simultaneously to elastic beanstalk. One thing to note with this change is that we will not be able to specify the S3 bucket name to which our package will be deployed. However, since this isn't a huge downside + Travis is no longer free for open-source, we will be sticking to GitHub actions.

These changes were tested with the DEV_BRANCH set to this branch (refs/heads/setup-github-actions). Refer to the Actions tab on this repo for example workflows run.

Jie Hao Kwa added 6 commits November 3, 2020 22:16
This commit creates a github actions workflow to deploy to elastic
beanstalk, if the branch being pushed to is either master, staging,
or staging-test. This workflow is based off gogovsg's github actions
ci workflow.
@kwajiehao kwajiehao requested a review from LoneRifle November 3, 2020 17:36
@kwajiehao kwajiehao force-pushed the setup-github-actions branch 3 times, most recently from 470b809 to a68adcf Compare November 3, 2020 22:14
Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests? =(

@kwajiehao kwajiehao merged commit f1adeab into staging Nov 4, 2020
@kwajiehao kwajiehao deleted the setup-github-actions branch November 4, 2020 06:38
@kwajiehao
Copy link
Contributor Author

No tests? =(

Will put some in place after beta is released

@kwajiehao kwajiehao restored the setup-github-actions branch November 4, 2020 09:11
harishv7 pushed a commit that referenced this pull request Feb 17, 2023
* feat: create github actions workflow to deploy to EB

This commit creates a github actions workflow to deploy to elastic
beanstalk, if the branch being pushed to is either master, staging,
or staging-test. This workflow is based off gogovsg's github actions
ci workflow.

* feat: set latest commit message as version desc.

* chore: rename staging-test branch reference to dev in workflow

* chore: remove unnecessary code

* chore: update CI settings

* chore: remove unused .travis.yml file

Co-authored-by: Jie Hao Kwa <jiehaokwa@Jies-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants