Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add logout endpoint #59

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Conversation

alexanderleegs
Copy link
Contributor

@alexanderleegs alexanderleegs commented Oct 14, 2020

This PR fixes the bug identified in issue #57. Currently, the frontend attempts to call a non-existent endpoint to log the user out. This PR adds in an endpoint to handle the user log out by clearing the existing cookie. To be reviewed with PR #154 on the isomercms-frontend repo.

Copy link
Contributor

@kwajiehao kwajiehao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexanderleegs alexanderleegs merged commit 455da9b into staging Oct 20, 2020
@alexanderleegs alexanderleegs deleted the Feat-add-endpoint-for-logout branch December 9, 2020 10:15
harishv7 pushed a commit that referenced this pull request Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants